Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop: add notification center, better cursors #784

Closed
wants to merge 1 commit into from

Conversation

humaidq-tii
Copy link
Member

Description of changes

This replaces mako with swaynotificationcenter, and makes cursors on the desktop and Qt apps consistent with GTK.

  • Makes cursor consistent with apps
    • This means the cursor theme won't change anymore when moving cursor from app->desktop.
    • Qt applications and chromium would load also the proper font.
  • Adds swaynotificationcenter
    • Adds patch for theme. The 'scss' file needs to be compiled, in the future we might make our own package for the swaync theme if needed.
    • Cog icon now loads the notification center, showing notifications.
    • Button for wifi settings is now in the notification center.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

This replaces mako with swaynotificationcenter, and makes cursors on the
desktop and Qt apps consistent with GTK.

Signed-off-by: Humaid Alqasimi <humaid.alqassimi@tii.ae>
@humaidq-tii humaidq-tii temporarily deployed to internal-build-workflow September 12, 2024 08:53 — with GitHub Actions Inactive
@humaidq-tii
Copy link
Member Author

Closing in favour of #790, cursor fix included in #791

@humaidq-tii humaidq-tii deleted the cursor-notifications branch October 1, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant