Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump some tools #875

Merged
merged 1 commit into from
Nov 1, 2024
Merged

bump some tools #875

merged 1 commit into from
Nov 1, 2024

Conversation

brianmcgillion
Copy link
Collaborator

@brianmcgillion brianmcgillion commented Oct 30, 2024

a partial bump of the available tools updates

includes the latest fixes for the control panel


Description of changes

Some small changes to microvm and the supporting tools

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
    all targets
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?
    minor version updates
    control panel updates -

Green/OK statuses for all VMs and services
Display settings: resolution and scale can be changed, confirmation popup added
Start and stop apps (only once because of some internal library bug)
Also button for launching audio control widget added, but not tested

@barnabakos
Copy link
Collaborator

1 commit: 83bacdf
commit is on top of latest tip of Ghaf main: 147f806

platform: Lenovo X1 Carbon; flash script; USB SSD

  • ci-test-automation suite: ok
  • starting apps: ok
  • regression / ad-hoc testing: ok

works:

  • statuses are green/OK for VMs and services
  • resolution & scale can be changed; there is confirmation popup

notes:

  • Control panel doesn't remember the applied resolution & scale settings after it was closed
    opening again shows the deafult values
  • setting the scale other than 100% will zoom in the top centre of the screen
    anything that doesn't fit that area will be unreachable: app menu; widgets; parts of running apps
  • resolution & scale settings are restored to default after logout / reboot / shutdown
  • taskbar doesn't get stretched to screen width when selecting a higher resolution
  • start / stop apps doesn't seem to work
  • button for launching audio control widget doesn't work

issues:

  • N/A

@barnabakos barnabakos added the Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon label Oct 31, 2024
@johannarautanen
Copy link

johannarautanen commented Oct 31, 2024

Tested on native Orin-AGX (flashed to the memory card) (commit: 83bacdf)

Working:

  • no new findings
  • net-vm can be connected and create wifi connection
  • all other ghaf apps can be launched and close
  • ci-test automation cases ok

Tested on cross-compile Orin-AGX (flashed to the emmc) (commit: 83bacdf)

Working:

  • no new findings
  • net-vm can be connected and create wifi connection
  • all other ghaf apps can be launched and close
  • ci-test automation cases ok

@johannarautanen johannarautanen added the Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin label Oct 31, 2024
@leivos-unikie leivos-unikie added the bug on Orin NX Issues found on NVIDIA Jetson NX Orin while checking this PR label Oct 31, 2024
@leivos-unikie
Copy link
Contributor

leivos-unikie commented Oct 31, 2024

Tested on Orin-NX (native build)

  • ci-test-automation passes except all tests requiring ssh connection to net-vm fail
  • tried ssh to net-vm also manually, it does not work (ping works), reboot or systemctl restart didn't help
  • also eth passthough to net-vm does not work (ping works)
  • removed the bug tag because after booting again with fresh native image I was not able to reproduce the issue with logging to net-vm, all automated tests passed

Tested also Orin NX with cross-compiled image

  • ci-test-automation passed
  • net-vm works fine, also after restart

Other known issues (also in mainline)

  • taskbar not available

@johannarautanen johannarautanen added the Tested on Orin AGX Cross This PR has been tested on NVIDIA Jetson AGX Orin cross-compiled label Oct 31, 2024
@leivos-unikie leivos-unikie added Tested on Orin NX Cross This PR has been tested on NVIDIA Jetson NX Orin cross-compiled Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin Tested on RISC-V This PR has been tested on RISC-V - Microchip Polarfire Icicle-kit board and removed bug on Orin NX Issues found on NVIDIA Jetson NX Orin while checking this PR Needs Testing CI Team to pre-verify labels Oct 31, 2024
a partial bump of the available tools updates

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@milva-unikie
Copy link

Tested on Lenovo-X1 (nixos-rebuild switch)

High cpu usage of Control Panel has been fixed.

@brianmcgillion brianmcgillion merged commit 3413dc0 into tiiuae:main Nov 1, 2024
16 checks passed
@brianmcgillion brianmcgillion deleted the bump-tools branch November 1, 2024 09:35
@dmitry-erin
Copy link
Contributor

1 commit: 83bacdf commit is on top of latest tip of Ghaf main: 147f806

platform: Lenovo X1 Carbon; flash script; USB SSD

  • ci-test-automation suite: ok
  • starting apps: ok
  • regression / ad-hoc testing: ok

works:

  • statuses are green/OK for VMs and services
  • resolution & scale can be changed; there is confirmation popup

notes:

  • Control panel doesn't remember the applied resolution & scale settings after it was closed
    opening again shows the deafult values
  • setting the scale other than 100% will zoom in the top centre of the screen
    anything that doesn't fit that area will be unreachable: app menu; widgets; parts of running apps
  • resolution & scale settings are restored to default after logout / reboot / shutdown
  • taskbar doesn't get stretched to screen width when selecting a higher resolution
  • start / stop apps doesn't seem to work
  • button for launching audio control widget doesn't work

issues:

  • N/A
  1. The display settings are under development, the task is not completed, so there are a lot of things to do (read current mode, all supported modes, adjusting the control panel's window to fit the scaled screen and etc)
  2. Restoring defaults after logout/rebooting/shutdwon is not control's panel issue, should be fixed in OS settings or somewhere else.
  3. Start&stop issue is known, responsible people are looking for a solution
  4. The advanced audio settings button sends the dbus message, which must be handled by audio widget. The receiving part is not ready yet as far as I know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on Orin AGX Cross This PR has been tested on NVIDIA Jetson AGX Orin cross-compiled Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin Tested on Orin NX Cross This PR has been tested on NVIDIA Jetson NX Orin cross-compiled Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin Tested on RISC-V This PR has been tested on RISC-V - Microchip Polarfire Icicle-kit board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants