Desktop: Refactor audio and brightness controls

[kajusnau]

Description of changes

1. Taskbar Audio Control and LabWC (F1, F2, F3) Hotkeys Now Use Pamixer

   • The audio-ctrl script has been removed, as it was simply a wrapper for existing pamixer commands.

2. Improved Responsiveness of Taskbar Audio and Brightness Controls:

   • Volume and brightness sliders in the quick settings widget are now more responsive.
   • Volume and brightness popups (displayed near the bottom of the screen) now appear more consistently and react to changes more quickly.

3. Removed audio-ctrl Script

Checklist for things done

• Summary of the proposed changes in the PR description
• More detailed description in the commit message(s)
• Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
• Contribution guidelines followed
• Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
• PR linked to architecture documentation and requirement(s) (ticket id)
• Test procedure described (or includes tests). Select one or more:
  • Tested on Lenovo X1 x86_64
  • Tested on Jetson Orin NX or AGX aarch64
  • Tested on Polarfire riscv64
• Author has run make-checks and it passes
• All automatic Github Action checks pass - see actions
• Author has added reviewers and removed PR draft status
• Change requires full re-installation
• Change can be updated with nixos-rebuild ... switch

Instructions for Testing

• List all targets that this applies to:
• Is this a new feature
  • List the test steps to verify:
    • Adjust system volume and display brightness using taskbar sliders and keyboard hotkeys
• If it is an improvement how does it impact existing functionality?

[josa41]

Maybe a bit minor issues..

[johannarautanen]

Tested on Lenovo-X1 (flashed to the SSD)

Working:

• Volume and brightness sliders in the quick settings are more responsive when with older version

• Volume and brightness popups now appear more consistently and react to changes more quickly.

• all other ghaf apps can be launched

• ci-test automation cases ok

Isssue:

• there are times when the volume or brightness popup isn't visible, but the functionality(volume and brightness) working ok.
  Not easy to reproduced, but when happened when tapping the the volume and brightness buttons and then ie volume popup is not anymore visible, but the F1, F2 and F3 changed the volume.
  And when you tap the brightness F5 and F6, the brightness popup comes visible and after that the volume popup is visible again when changing the volume.

[kajusnau]

Tested on Lenovo-X1 (flashed to the SSD)

Working:

• Volume and brightness sliders in the quick settings are more responsive when with older version
• Volume and brightness popups now appear more consistently and react to changes more quickly.
• all other ghaf apps can be launched
• ci-test automation cases ok

Isssue:

• there are times when the volume or brightness popup isn't visible, but the functionality(volume and brightness) working ok.
  Not easy to reproduced, but when happened when tapping the the volume and brightness buttons and then ie volume popup is not anymore visible, but the F1, F2 and F3 changed the volume.
  And when you tap the brightness F5 and F6, the brightness popup comes visible and after that the volume popup is visible again when changing the volume.

The issue described seems to be the expected behavior of how the popups appear in the stack.
Since both popups are defined to appear in the overlay, whichever one opens last appears on top of the other.
For example, adjusting volume and brightness in that order makes the volume popup appear then get immediately covered by the brightness popup in the same layer. Both popups are on a 2s timer, which can be interrupted.

[kajusnau]

Maybe a bit minor issues..

Updated PR, most of the mentioned issues have been addressed.

[johannarautanen]

Tested on Lenovo-X1 (flashed to the SSD) (Commit: 1950991)

Working:

• Volume and brightness sliders working
• Popups appeared when changing volume and brightness
  - all other ghaf apps can be launched
  - ci-test automation cases ok

Notes:

• when the "Terminal"-menu is opened and stayed the screen, the volume and brightness cannot be changed via F1, F2, F3, F5 and F6. After you really open the Terminal-app or close the Terminal-menu, then hotkeys worked again.
• When you open then the youtube-page via chromium or microsoft teams meeting, then there appeared 3 times volume popups and when you close the page or stop the meeting, again volume popups appeared couple of times.
• Once when "playing" with the "Terminal"-menu and volume popups, then popup stayed on the screen, doesn't go way time being or after lock the screen or closing other apps from the screen. After logout the volume popup disappeared.
  Will create separate issues of these notes.