nuttx: Update submodule to pull i2c fixes #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency should be to nuttx_app_bins target, since nsh is deleted from the /bin folder (to not allow users to execute it). Otherwise the nsh target will always be re-build (as it does not exist). Using nuttx_app_bins as the dependency fixes it, and when the content of nsh is changed it also re-triggers all relevant targets.
The only broken dependency after this change is:
${OUTDIR}/${OUTPREFIX}_romfsimg.h
The file path is a symbolic link and for some reason CMake / Ninja does
not understand this. Maybe it will get fixed some day.
jlaitine
approved these changes
Jan 23, 2025
jlaitine
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.