sbomnix: Remove command-line argument: --type #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `--type` command-line argument from sbomnix. Instead, change sbomnix so that it support `--buildtime` argument to align the command-line usage with other tools. - Update relevant documentation and tests Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
henrirosten
force-pushed
the
sbomnix-replace-type-with-buildtime
branch
from
affcc40 to
d451ca2
Compare
alextserepov
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
--typecommand-line argument from sbomnix replacing it with--buildtimeargument to align the command-line usage with other tools in this repository. Also, update relevant documentation and tests.Note: this change breaks the command line usage of the
sbomnixtool for those users who use the--typeargument, and it should be replaced as follows:--type=buildtimeshould be replaced with--buildtimeafter this change--type=bothshould be replaced with--buildtimeafter this change--type=runtimeis still the default mode (i.e. the absence of--buildtime)