Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat sparo metric #78

Merged
merged 6 commits into from
Jun 29, 2024
Merged

Feat sparo metric #78

merged 6 commits into from
Jun 29, 2024

Conversation

chengcyber
Copy link
Member

@chengcyber chengcyber commented Jun 27, 2024

Basic Checks

Have you run rush change for this change?

  • Yes
  • No

If No, please run rush change before, this is necessary.

If adding a new feature, the PR's description includes:

  • Reason for adding this feature
  • How to use
  • A basic example

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Summary

  1. Improve the logic to check existence of a branch
  2. Improve the logic to accurately report success data

Detail

  1. git ls-remote --exist-code explicitly returns exit code 2 to indicate the branch is missing remotely. The new logic respects this logic, that says other exit code will be treated the branch exists remotely.
    CleanShot 2024-06-27 at 16 51 03@2x

  2. Previously, all data are sent via telemetry service. After this PR, data will be sent only for success commands.

How to test it

Local

@jzhang026 jzhang026 merged commit 70ecbe4 into main Jun 29, 2024
3 checks passed
@jzhang026 jzhang026 deleted the feat-sparo-metric branch June 29, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants