Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"sparo fetch" behaves the same as "git fetch" when no remote or no branches specified #81

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

chengcyber
Copy link
Member

@chengcyber chengcyber commented Jul 11, 2024

Basic Checks

Have you run rush change for this change?

  • Yes
  • No

If No, please run rush change before, this is necessary.

If adding a new feature, the PR's description includes:

  • Reason for adding this feature
  • How to use
  • A basic example

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Summary

"sparo fetch" behaves the same as "git fetch" when no remote or no branches specified

Detail

Right now, sparo fetch origin will be treated as git fetch origin <current_branch>. This doesn't follow the same behavior as git fetch does. This PR fixes it and get aligned with git fetch

How to test it

Copy link
Member

@octogonz octogonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chengcyber chengcyber merged commit 3c916a2 into main Jul 11, 2024
3 checks passed
@chengcyber chengcyber deleted the feat-fetch-behavior branch July 11, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants