Pass user context to pd.NewClientWithContext in NewClientWithOpts #1019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new rawkv client in
NewClientWithOpts
we neglect to pass through the user's context to the pd client. This means any deadline/timeout set by the user is not adhered to. By default the call topd.NewClientWithContext
will retry for 100 attempts with a one second sleep between each attempt. This is annoying as a user if we want to set a shorter deadline. Fix the issue by callingpd.NewClientWithContext
and passing through the user's context.Using a modified version of
example/rawkv/rawkv.go
which sets the context deadline to 5 seconds and attempts to dial a bogus endpoint as an example. Before the fix:After the fix: