tso: merge lastTS and lastArrivalTS into an atomic pointer #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
you06
force-pushed
the
tso/merge-last-ts
branch
from
f07a0cd
to
47a2c0b
Compare
|
@JmPotato Please take a look |
JmPotato
approved these changes
Nov 14, 2023
cfzjywxk
reviewed
Nov 14, 2023
Signed-off-by: you06 <you1474600@gmail.com>
you06
added a commit
to you06/client-go
that referenced
this pull request
Nov 20, 2023
* fix the issue that stale timestamp may be a future one Signed-off-by: you06 <you1474600@gmail.com> * add regression test Signed-off-by: you06 <you1474600@gmail.com> * lazy init lastTSO Signed-off-by: you06 <you1474600@gmail.com> * fix panic Signed-off-by: you06 <you1474600@gmail.com> * address comment Signed-off-by: you06 <you1474600@gmail.com> --------- Signed-off-by: you06 <you1474600@gmail.com>
disksing
pushed a commit
that referenced
this pull request
Nov 20, 2023
you06
added a commit
to you06/client-go
that referenced
this pull request
Nov 20, 2023
* fix the issue that stale timestamp may be a future one Signed-off-by: you06 <you1474600@gmail.com> * add regression test Signed-off-by: you06 <you1474600@gmail.com> * lazy init lastTSO Signed-off-by: you06 <you1474600@gmail.com> * fix panic Signed-off-by: you06 <you1474600@gmail.com> * address comment Signed-off-by: you06 <you1474600@gmail.com> --------- Signed-off-by: you06 <you1474600@gmail.com>
disksing
pushed a commit
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1053
The update of
lastTSandlastArrivalTSshould be atomic, unless we may get newlateTSwith oldlastArrivalTSwhen callingGetStaleTimestampwhich may lead to a future TSO.This PR merge
lastTSandlastArrivalTSinto an atomic pointer and fix the future stale TSO bug.