Fix comment of SuspendTime
#1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekexium
force-pushed
the
fix-comment-suspendtime
branch
from
5f8b688
to
aa79e39
Compare
Signed-off-by: ekexium <eke@fastmail.com>
ekexium
force-pushed
the
fix-comment-suspendtime
branch
from
aa79e39
to
d08b582
Compare
glorv
reviewed
Nov 13, 2023
| SuspendTime time.Duration | ||
| // Off-cpu wall time elapsed in TiKV side. Usually this includes queue waiting time and | ||
| // other kind of waits in series. | ||
| WaitTime time.Duration | ||
| // KvReadWallTime is the time used in KV Scan/Get. | ||
| // KvReadWallTime is the time used in KV Scan/Get. For get/batch_get, |
There was a problem hiding this comment.
Suggested change
| // KvReadWallTime is the time used in KV Scan/Get. For get/batch_get, | |
| // KvReadWallTime is the time used in KV Scan/Get. For coprocessor requests, |
Coprocessor request queue time is more notable due to reschedule
There was a problem hiding this comment.
My point was that for get/batch_get, the field covers more procedures
Signed-off-by: ekexium <eke@fastmail.com>
ekexium
force-pushed
the
fix-comment-suspendtime
branch
from
2c19e67
to
616154c
Compare
disksing
approved these changes
Nov 14, 2023
iosmanthus
added a commit
that referenced
this pull request
Dec 20, 2023
Co-authored-by: cfzjywxk <cfzjywxk@gmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zzm <zhouzemin@pingcap.com> Co-authored-by: husharp <jinhao.hu@pingcap.com> Co-authored-by: you06 <you1474600@gmail.com> Co-authored-by: buffer <doufuxiaowangzi@gmail.com> Co-authored-by: 3pointer <qdlc2010@gmail.com> Co-authored-by: buffer <1045931706@qq.com> Co-authored-by: husharp <ihusharp@gmail.com> Co-authored-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: Smilencer <smityz@qq.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: zyguan <zhongyangguan@gmail.com> Co-authored-by: Jack Yu <jackysp@gmail.com> Co-authored-by: Weizhen Wang <wangweizhen@pingcap.com> Co-authored-by: lucasliang <nkcs_lykx@hotmail.com> Co-authored-by: healthwaite <148101100+healthwaite@users.noreply.github.com> Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn> Co-authored-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: ekexium <eke@fastmail.com> Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com> Co-authored-by: glorv <glorvs@163.com> Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com> resolve locks interface for tidb gc_worker (#945) fix some issues of replica selector (#910) (#942) fix some issues of replica selector (#910) fix issue of configure kv timeout not work when disable batch client (#980) fix batch-client wait too long and add some metrics (#973) fix batch-client wait too long and add some metrics (#973)" (#984) fix data race at the aggressiveLockingDirty (#913) fix MinSafeTS might be set to MaxUint64 permanently (#994) fix: fix invalid nil pointer when trying to record Store.SlownessStat. (#1017) Fix batch client batchSendLoop panic (#1021) fix request source tag unset (#1025) Fix comment of `SuspendTime` (#1057)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on current TiKV implementation, modify the comments to make them more precise.