feat: check kill signal in 2pc committer #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekexium
force-pushed
the
check-kill-signal-in-committer
branch
4 times, most recently
from
3ab3d54
to
797efcb
Compare
Signed-off-by: ekexium <eke@fastmail.com>
ekexium
force-pushed
the
check-kill-signal-in-committer
branch
from
797efcb
to
18bd3d1
Compare
disksing
reviewed
Dec 26, 2023
| // ErrTiKVStaleCommand is the error that the command is stale in tikv. | ||
| ErrTiKVStaleCommand = errors.New("tikv stale command") | ||
| // ErrTiKVMaxTimestampNotSynced is the error that tikv's max timestamp is not synced. | ||
| ErrTiKVMaxTimestampNotSynced = errors.New("tikv max timestamp not synced") | ||
| // ErrLockAcquireFailAndNoWaitSet is the error that acquire the lock failed while no wait is setted. | ||
| ErrLockAcquireFailAndNoWaitSet = errors.New("lock acquired failed and no wait is setted") | ||
| ErrLockAcquireFailAndNoWaitSet = errors.New("lock acquired failed and no wait is set") |
Signed-off-by: ekexium <eke@fastmail.com>
ekexium
force-pushed
the
check-kill-signal-in-committer
branch
from
55ce5be
to
bdd38fa
Compare
disksing
approved these changes
Dec 26, 2023
ti-chi-bot
added
the
needs-cherry-pick-release-7.5
ekexium
added a commit
to ekexium/client-go
that referenced
this pull request
Feb 18, 2024
Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com>
cfzjywxk
added a commit
that referenced
this pull request
Feb 19, 2024
* feat: check kill signal in 2pc committer (#1084) Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> * ErrQueryInterrupted with parameters (#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (#1102)" (#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
ti-chi-bot
added
needs-cherry-pick-release-7.1
ti-chi-bot
added
the
needs-cherry-pick-release-7.1
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* feat: check kill signal in 2pc committer (tikv#1084) Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> * ErrQueryInterrupted with parameters (tikv#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* feat: check kill signal in 2pc committer (tikv#1084) Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> * ErrQueryInterrupted with parameters (tikv#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* feat: check kill signal in 2pc committer (tikv#1084) Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> * ErrQueryInterrupted with parameters (tikv#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <eke@fastmail.com> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> Signed-off-by: zzm <zhouzemin@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref pingcap/tidb#49643