P-DML: for AlreadyExist error, attach the value from flushingMemDB #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
…hingMemDB to it Signed-off-by: ekexium <eke@fastmail.com>
ekexium
force-pushed
the
pipelined-dml-dup-key-message
branch
from
b515193 to
eeb30c3
Compare
cfzjywxk
reviewed
Mar 12, 2024
Signed-off-by: ekexium <eke@fastmail.com>
you06
approved these changes
Mar 13, 2024
cfzjywxk
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to provide the value for TiDB to generate the corresponding duplicate entry error.
For vanilla memdb, the value was obtained by memdb.SelectValue().
For pipelined memdb, the
flushingMemDBwill be cleared once an error returned. So we choose to retain the value in the error struct.