*: fix panic in get cause error #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs520 <crazycs520@gmail.com>
cfzjywxk
reviewed
May 16, 2024
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
cfzjywxk
approved these changes
May 16, 2024
MyonKeminta
approved these changes
May 16, 2024
nolouch
reviewed
May 16, 2024
| @@ -2211,7 +2222,11 @@ func (s *RegionRequestSender) onSendFail(bo *retry.Backoffer, ctx *RPCContext, r | |||
| } | |||
| } | |||
| } | |||
| metrics.TiKVRPCErrorCounter.WithLabelValues(errors.Cause(err).Error(), storeLabel).Inc() | |||
| if errStr := getErrMsg(err); len(errStr) > 0 { | |||
| metrics.TiKVRPCErrorCounter.WithLabelValues(getErrMsg(err), storeLabel).Inc() | |||
There was a problem hiding this comment.
will the error message be too long?
There was a problem hiding this comment.
It's possible, but I haven't seen any error message very long yet.
There was a problem hiding this comment.
my issue origin error message is:
There was a problem hiding this comment.
Great, I think this error length is acceptable.
crazycs520
added a commit
to crazycs520/client-go
that referenced
this pull request
May 16, 2024
Signed-off-by: crazycs520 <crazycs520@gmail.com>
cfzjywxk
pushed a commit
that referenced
this pull request
May 16, 2024
13 tasks
crazycs520
added a commit
to crazycs520/client-go
that referenced
this pull request
May 16, 2024
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Merged
13 tasks
cfzjywxk
pushed a commit
that referenced
this pull request
May 21, 2024
* improve region request log for diagnose Signed-off-by: crazycs520 <crazycs520@gmail.com> * remove useless filed Signed-off-by: crazycs520 <crazycs520@gmail.com> * use context logger as much as possible (#908) Signed-off-by: crazycs520 <crazycs520@gmail.com> * add leader peer id log Signed-off-by: crazycs520 <crazycs520@gmail.com> * *: fix panic in get cause error (#1344) Signed-off-by: crazycs520 <crazycs520@gmail.com> * address comment Signed-off-by: crazycs520 <crazycs520@gmail.com> --------- Signed-off-by: crazycs520 <crazycs520@gmail.com>
nolouch
pushed a commit
to nolouch/client-go
that referenced
this pull request
Sep 13, 2024
Signed-off-by: crazycs520 <crazycs520@gmail.com>
nolouch
pushed a commit
to nolouch/client-go
that referenced
this pull request
Sep 13, 2024
Signed-off-by: crazycs <crazycs520@gmail.com> Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1343