fix issue that store's liveness may incorrectly marked as unreachable when the store restarts with label changed #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when the store restarts with label changed Signed-off-by: crazycs520 <crazycs520@gmail.com>
ti-chi-bot
bot
added
the
dco-signoff: yes
crazycs520
commented
Jul 29, 2024
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
zyguan
approved these changes
Jul 30, 2024
Signed-off-by: crazycs520 <crazycs520@gmail.com>
|
can you also change the message from region unavailable to store unavailable if it can not able to connect to store. It will help to root cause these type of issues. |
Thanks for the suggestion, we may change this error messge later, but not in this PR, since It's not easy to change. |
cfzjywxk
approved these changes
Jul 31, 2024
cfzjywxk
merged commit 50d9718
into
tikv:tidb-6.5-with-kv-timeout-feature
8 of 10 checks passed
crazycs520
added a commit
to crazycs520/client-go
that referenced
this pull request
Jul 31, 2024
… when the store restarts with label changed (tikv#1402) Signed-off-by: crazycs520 <crazycs520@gmail.com>
13 tasks
cfzjywxk
pushed a commit
that referenced
this pull request
Aug 7, 2024
… when the store restarts with label changed (#1402) (#1417) * fix issue that store's liveness may incorrectly marked as unreachable when the store restarts with label changed (#1407) Signed-off-by: crazycs520 <crazycs520@gmail.com> --------- Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix ci Signed-off-by: crazycs520 <crazycs520@gmail.com> --------- Signed-off-by: crazycs520 <crazycs520@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1401