retry stale read on follower if leader timeout #1450
+11
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue number : tikv/tikv#17422
Currently stale read is always retried as leader read or follower read. Follower read can overwhelm the leader if is leader raft state machine is slow.
In this fix, request is retried as stale reads to replica if leader read returns deadline_exceeded error.
After this fix :
If original request is doing stale read
Retry 1 : Try Leader read
if error is deadline exceeded
Retry 2 : Try replica 1 with stale read
Retry 3 : try replica 2 with stale read
If there is any other error
Retry 2: Try replica 1 with follower read
Retry 3 : Try replica 2 with follower read