Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn-file: Sort by chunks first during group to batches #1456

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented Sep 2, 2024

Changes

  • Sort by chunks first during groupToBatches
    • To properly handle the scene that batch with bigger chunk having region with smaller start key, which is caused by region merge during grouping.

Signed-off-by: Ping Yu <yuping@pingcap.cn>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 2, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 2, 2024
Copy link

ti-chi-bot bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coocood, iosmanthus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 2, 2024
Copy link

ti-chi-bot bot commented Sep 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-02 07:11:40.638367984 +0000 UTC m=+255625.156420909: ☑️ agreed by coocood.
  • 2024-09-02 07:23:18.689105939 +0000 UTC m=+256323.207158886: ☑️ agreed by iosmanthus.

@pingyu pingyu merged commit 53f61c5 into tikv:tidb-cse-7.5 Sep 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants