internal/client: remove the lock for idle connection recycle #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After mock testing, I find #270 can not sufficient to solve the problem.
To my surprise, RLock can block RLock in some case
The final decision is to reduce the granularity of the lock.
Just lock the modification of the
map
...There is a risk that an idle connection become active again, since
recycleMu
is removed to protect such case.In very rare case, someone is maybe using the connection and the connection is closed by the recycle operation.
I think the outcome is acceptable, comparing to the recycle operation blocks the
SendRequest()
function.