txn: add newly inserted flag for memdb key node #369
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cfzjywxk lsswxrxr@163.com
Solution for pingcap/tidb#27564.
Add a new flag for key in memdb, when the key node is allocated by a PUT operation, add this flag to the key. This mark is used to identify the inserted keys generated from the transaction iteself, so that the delete operations on these keys could be skipped committing this transaction, see the comments for details in the issue. There are mainly two situations:
PUT
opertion and it existing node inmemdb
is a node generated byLOCK
. This means the insert is done followed aselect for update
.This change could be risky, need to think it over.