Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region_cache: refine GetTiFlashComputeRPCContextByConsistentHash #644

Merged
merged 3 commits into from
Dec 19, 2022

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Dec 17, 2022

Signed-off-by: guo-shaoge shaoge1994@163.com

Move GetTiFlashComputeStores() outside of GetTiFlashComputeRPCContextByConsistentHash() to help filter alive tiflash_compute nodes.

Related tidb pr: pingcap/tidb#40008

…detect alive)

Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Copy link
Member

@cosven cosven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to add unit test?

internal/locate/region_request.go Show resolved Hide resolved
Copy link
Member

@gengliqi gengliqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gengliqi gengliqi merged commit a4f5c00 into tikv:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants