tikv/safeTS: obtain min-resolved-ts by store list #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuSharp
commented
Aug 2, 2023
HuSharp
force-pushed
the
get_min_resolved_ts_by_stores
branch
from
46d5ceb
to
681f10d
Compare
Signed-off-by: husharp <jinhao.hu@pingcap.com>
HuSharp
force-pushed
the
get_min_resolved_ts_by_stores
branch
from
681f10d
to
c5bf330
Compare
JmPotato
reviewed
Aug 2, 2023
Signed-off-by: husharp <jinhao.hu@pingcap.com>
JmPotato
reviewed
Aug 2, 2023
HuSharp
force-pushed
the
get_min_resolved_ts_by_stores
branch
from
9b56a52
to
785d22e
Compare
HuSharp
force-pushed
the
get_min_resolved_ts_by_stores
branch
from
785d22e
to
0930be9
Compare
Signed-off-by: husharp <jinhao.hu@pingcap.com>
HuSharp
force-pushed
the
get_min_resolved_ts_by_stores
branch
from
4a3253a
to
3f36b93
Compare
Signed-off-by: husharp <jinhao.hu@pingcap.com>
|
@nolouch PTAL, thx! |
HuSharp
force-pushed
the
get_min_resolved_ts_by_stores
branch
3 times, most recently
from
a376cf3
to
9bd870e
Compare
Signed-off-by: husharp <jinhao.hu@pingcap.com>
HuSharp
force-pushed
the
get_min_resolved_ts_by_stores
branch
from
9bd870e
to
b771e63
Compare
lhy1024
approved these changes
Aug 14, 2023
JmPotato
reviewed
Aug 16, 2023
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
HuSharp
force-pushed
the
get_min_resolved_ts_by_stores
branch
from
2a603e8
to
6e0f17d
Compare
Signed-off-by: husharp <jinhao.hu@pingcap.com>
HuSharp
force-pushed
the
get_min_resolved_ts_by_stores
branch
from
6e0f17d
to
ae859e2
Compare
JmPotato
reviewed
Sep 1, 2023
Signed-off-by: husharp <ihusharp@gmail.com>
JmPotato
approved these changes
Sep 5, 2023
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #922
Background
Nowadays we have 2 api interface for obtaining min resolved ts
There are 2 repair step in this pr:
approach Ito get cluster's min resolved ts when @@txn_scope is global.approach IIfor each store, which is not necessary.We can extend the
approach Iparams to obtain specified store via a list to reduce the cost per call after api: Extend the min-resolved-ts api to support getting the specified store pd#6880 mergedSummary pr
step 1
judge @@txn_scope value which from the config:
approach II.step 2
use
approach I's extension to get all stores.