Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use tidb_kv_read_timeout as first kv request timeout (#919) #948

Merged
merged 1 commit into from
Aug 23, 2023
Merged

use tidb_kv_read_timeout as first kv request timeout (#919) #948

merged 1 commit into from
Aug 23, 2023

Conversation

crazycs520
Copy link
Contributor

cherry-pick #919

@crazycs520 crazycs520 marked this pull request as ready for review August 17, 2023 09:47
@crazycs520 crazycs520 mentioned this pull request Aug 21, 2023
Merged
12 tasks
you06
you06 reviewed Aug 21, 2023
View reviewed changes
internal/locate/region_request.go Outdated Show resolved Hide resolved
internal/locate/region_request3_test.go Outdated Show resolved Hide resolved
@cfzjywxk
Copy link
Contributor

@you06 PTAL

@cfzjywxk
Copy link
Contributor

@crazycs520
It seems the DCO fails, commits need to be signed with "-s" in git.

@crazycs520
use tidb_kv_read_timeout as first kv request timeout (tikv#919)
1046d55 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@cfzjywxk cfzjywxk merged commit 25cbaa3 into tikv:tidb-6.5-with-kv-timeout-feature Aug 23, 2023
1 check passed
cfzjywxk pushed a commit that referenced this pull request Aug 29, 2023
@crazycs520 @cfzjywxk
use tidb_kv_read_timeout as first kv request timeout (#919) (#948)
dfae543 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@cfzjywxk cfzjywxk mentioned this pull request Aug 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@you06 you06 you06 left review comments

@cfzjywxk cfzjywxk cfzjywxk left review comments

@bufferflies bufferflies bufferflies approved these changes

@zyguan zyguan Awaiting requested review from zyguan

@ekexium ekexium Awaiting requested review from ekexium

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazycs520 @cfzjywxk @you06 @bufferflies