min-safe-ts: fix MinSafeTS might be set to MaxUint64 permanently #998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #991
cherry-pick #994
The core question is the getter
PD API
to not executego func which for KV request
, resulting in not updatingsafeTSMap
.updateMinSafeTS
relies onsafeTSMap
which makes sense(because actually, we can callupdateMinSafeTS
tokvReuqestUpdater
[to indicate func base]).minsafeTS
to make sure when API fails we can fall back to the original way which is by kv request.updateMinSafeTS
will returnmaxUnit64
when the first kv request returns 0 and then althoughPD API
returns correctly[maybe kv is not initialized], TS can not changemaxUnit64
.maxUnit64
as 0 which means there is an initial state.