-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scan exception when the start key is empty #199
Merged
birdstorm
merged 1 commit into
tikv:master
from
birdstorm:fix-scan-with-empty-start-key
Jun 17, 2021
Merged
Fix scan exception when the start key is empty #199
birdstorm
merged 1 commit into
tikv:master
from
birdstorm:fix-scan-with-empty-start-key
Jun 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
marsishandsome
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: birdstorm <samuelwyf@hotmail.com> fix assert order Signed-off-by: birdstorm <samuelwyf@hotmail.com> add comment Signed-off-by: birdstorm <samuelwyf@hotmail.com> fix empty range Signed-off-by: birdstorm <samuelwyf@hotmail.com> add debug log Signed-off-by: birdstorm <samuelwyf@hotmail.com> fix test Signed-off-by: birdstorm <samuelwyf@hotmail.com> remove debug log Signed-off-by: birdstorm <samuelwyf@hotmail.com>
birdstorm
force-pushed
the
fix-scan-with-empty-start-key
branch
from
June 17, 2021 07:42
2ae4345
to
6a2e880
Compare
/run-all-tests |
Little-Wallace
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
approved these changes
Jun 17, 2021
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Jun 17, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-3.1 in PR #200 |
birdstorm
added a commit
to ti-srebot/client-java
that referenced
this pull request
Jun 17, 2021
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
birdstorm
added a commit
that referenced
this pull request
Jun 18, 2021
Signed-off-by: birdstorm <samuelwyf@hotmail.com> Co-authored-by: birdstorm <samuelwyf@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: birdstorm samuelwyf@hotmail.com
What problem does this PR solve?
Close #187
What is changed and how it works?
Change the check condition for the scan operations to allow empty start key.
Check List
Tests
Related changes