Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scan exception when the start key is empty #199

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

birdstorm
Copy link
Collaborator

Signed-off-by: birdstorm samuelwyf@hotmail.com

What problem does this PR solve?

Close #187

What is changed and how it works?

Change the check condition for the scan operations to allow empty start key.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

@birdstorm
Copy link
Collaborator Author

/run-all-tests

Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: birdstorm <samuelwyf@hotmail.com>

fix assert order

Signed-off-by: birdstorm <samuelwyf@hotmail.com>

add comment

Signed-off-by: birdstorm <samuelwyf@hotmail.com>

fix empty range

Signed-off-by: birdstorm <samuelwyf@hotmail.com>

add debug log

Signed-off-by: birdstorm <samuelwyf@hotmail.com>

fix test

Signed-off-by: birdstorm <samuelwyf@hotmail.com>

remove debug log

Signed-off-by: birdstorm <samuelwyf@hotmail.com>
@birdstorm birdstorm force-pushed the fix-scan-with-empty-start-key branch from 2ae4345 to 6a2e880 Compare June 17, 2021 07:42
@birdstorm
Copy link
Collaborator Author

/run-all-tests

Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm birdstorm merged commit c6d7f04 into tikv:master Jun 17, 2021
@birdstorm birdstorm deleted the fix-scan-with-empty-start-key branch June 17, 2021 07:56
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Jun 17, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.1 in PR #200

birdstorm added a commit to ti-srebot/client-java that referenced this pull request Jun 17, 2021
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
birdstorm added a commit that referenced this pull request Jun 18, 2021
Signed-off-by: birdstorm <samuelwyf@hotmail.com>

Co-authored-by: birdstorm <samuelwyf@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] raw kv scan cannot start with empty start key
4 participants