Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd backoff use tikv.rawkv.default_backoff_in_ms #288

Merged
merged 1 commit into from
Oct 22, 2021
Merged

pd backoff use tikv.rawkv.default_backoff_in_ms #288

merged 1 commit into from
Oct 22, 2021

Conversation

marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Oct 21, 2021 •
edited
Loading

Signed-off-by: marsishandsome marsishandsome@gmail.com

What problem does this PR solve?

user cannot control the backoff time for pd, currently 40s written in code.

What is changed and how it works?

  1. use tikv.rawkv.default_backoff_in_ms as default backoff in RegionManager and RegionStoreClient
  2. let RawKVClient share the same backoff in all the steps, e.g. put：get region from pd -> put key value to tikv

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome marsishandsome force-pushed the feature/pd-backoff branch 2 times, most recently from ca4da98 to 7f54c2c Compare October 21, 2021 05:31
@marsishandsome
pd backoff use tikv.rawkv.default_backoff_in_ms
e06c2e2 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

birdstorm
birdstorm approved these changes Oct 21, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome merged commit fb561e7 into tikv:release-3.1 Oct 22, 2021
marsishandsome added a commit to marsishandsome/client-java that referenced this pull request Oct 22, 2021
@marsishandsome
pd backoff use tikv.rawkv.default_backoff_in_ms (tikv#288)
c02f78d 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome marsishandsome mentioned this pull request Oct 22, 2021
Merged
marsishandsome added a commit that referenced this pull request Oct 22, 2021
@marsishandsome
pd backoff use tikv.rawkv.default_backoff_in_ms (#288) (#291)
599da19 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birdstorm birdstorm birdstorm approved these changes

@Little-Wallace Little-Wallace Awaiting requested review from Little-Wallace

Assignees
No one assigned
Labels
status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marsishandsome @birdstorm @ti-srebot