[to #526] Add codecov on Github Action #524
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # PD Configuration. | ||
| [replication] | ||
| enable-placement-rules = true | ||
| max-replicas = 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # TiKV Configuration. | ||
|
|
||
| [raftstore] | ||
| # set store capacity, if no set, use disk capacity. | ||
| capacity = "8G" | ||
| pd-heartbeat-tick-interval = "2s" | ||
| pd-store-heartbeat-tick-interval = "5s" | ||
| split-region-check-tick-interval = "1s" | ||
|
|
||
| [storage] | ||
| enable-ttl = true | ||
|
|
||
| [rocksdb] | ||
| max-open-files = 10000 | ||
|
|
||
| [raftdb] | ||
| max-open-files = 10000 | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # TiKV Configuration. | ||
|
|
||
| [raftstore] | ||
| # set store capacity, if no set, use disk capacity. | ||
| capacity = "8G" | ||
| pd-heartbeat-tick-interval = "2s" | ||
| pd-store-heartbeat-tick-interval = "5s" | ||
| split-region-check-tick-interval = "1s" | ||
|
|
||
| [rocksdb] | ||
| max-open-files = 10000 | ||
|
|
||
| [raftdb] | ||
| max-open-files = 10000 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - master | ||
|
|
||
| jobs: | ||
| format: | ||
| name: Check Format | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set up JDK 8 | ||
| uses: actions/setup-java@v2 | ||
| with: | ||
| java-version: '8.0' | ||
| distribution: 'adopt' | ||
| - run: | | ||
| ./dev/javafmt | ||
| if [[ $(git diff) != "" ]] | ||
| then | ||
| echo "code format error, please run the following commands:" | ||
| echo " ./dev/javafmt" | ||
| exit 1 | ||
| fi | ||
|
|
||
| integration-test: | ||
| name: Integration Test - ${{ matrix.tikv_version }} | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| tikv_version: [nightly, v5.0.4, v5.3.0, v5.4.0] | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set up JDK 8 | ||
| uses: actions/setup-java@v2 | ||
| with: | ||
| java-version: '8.0' | ||
| distribution: 'adopt' | ||
| - name: Install TiUP | ||
| run: curl --proto '=https' --tlsv1.2 -sSf https://tiup-mirrors.pingcap.com/install.sh | sh | ||
| - name: Start TiUP Playground | ||
| run: | | ||
| # Start TiKV in APIV1TTL | ||
| /home/runner/.tiup/bin/tiup playground ${{ matrix.tikv_version }} --mode tikv-slim --kv 1 --without-monitor --kv.config /home/runner/work/client-java/client-java/.github/config/tikv_rawkv.toml --pd.config /home/runner/work/client-java/client-java/.github/config/pd.toml &> raw.out 2>&1 & | ||
|
There was a problem hiding this comment. What about adding a step to install necessary components via There was a problem hiding this comment. It will add up the complexity of deciding which components are required by the playground. There was a problem hiding this comment. Only PD and TiKV are needed. There was a problem hiding this comment. ngm may be needed afterwards There was a problem hiding this comment. I've tested with various ways but tiup seems too easy to run into race conditions so that the sleep time can not be eliminated. So I've reverted all attempts for |
||
|
|
||
| # The first run of `tiup` has to download all components so it'll take longer. | ||
| sleep 1m 30s | ||
zz-jason marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| # Start TiKV in APIV1 | ||
| /home/runner/.tiup/bin/tiup playground ${{ matrix.tikv_version }} --mode tikv-slim --kv 1 --without-monitor --kv.config /home/runner/work/client-java/client-java/.github/config/tikv_txnkv.toml --pd.config /home/runner/work/client-java/client-java/.github/config/pd.toml &> txn.out 2>&1 & | ||
|
|
||
| sleep 30s | ||
|
|
||
| # Parse PD address from `tiup` output | ||
| echo "RAWKV_PD_ADDRESSES=$(cat raw.out | grep -oP '(?<=PD client endpoints: \[)[0-9\.:]+(?=\])')" >> $GITHUB_ENV | ||
| echo "TXNKV_PD_ADDRESSES=$(cat txn.out | grep -oP '(?<=PD client endpoints: \[)[0-9\.:]+(?=\])')" >> $GITHUB_ENV | ||
|
|
||
| # Log the output | ||
| echo "$(cat raw.out)" >&2 | ||
| echo "$(cat txn.out)" >&2 | ||
| - name: Run Integration Test | ||
| run: mvn clean test | ||
| - name: Upload coverage | ||
| uses: codecov/codecov-action@v2 | ||
| with: | ||
| files: ${{ github.workspace }}/target/site/jacoco/jacoco.xml | ||
| fail_ci_if_error: true | ||
| verbose: true | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, how about [v5.0.0, v5.1.0, v5.2.0, v5.3.0, v5.4.0]?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to point to the latest patch release on each
major.minor.patchtikv version?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid it's too much for pull request ci. It's better to do it on release or nightly ci. Anyway,
tiup list tikv | awk '{print $1}'should do the job.