Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #572] misc: fix syntax issues in github issue/pr templates #573

Merged
merged 4 commits into from
Mar 28, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ labels: type/bug

### 4. What did you expect to see? (Required)

### 5. What is your Java Client and TiKV version? (Required)
### 5. What are your Java Client and TiKV versions? (Required)

- Client Java:
- TiKV:
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ frustrated when [...] -->
you've considered. -->

**Teachability, Documentation, Adoption, Migration Strategy:**
<!-- If you can, explain some scenarios how users might use this, situations it
<!-- If you can, explain some scenarios of how users might use this, situations it
would be helpful in. Any API designs, mockups, or diagrams are also helpful.
-->
6 changes: 3 additions & 3 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Issue Number: close #issue_number

Problem Description: **TBD**

### What is changed and how it works?
### What is changed and how does it work?



Expand All @@ -17,13 +17,13 @@ Problem Description: **TBD**
<!-- REMOVE the items that are not applicable -->
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has methods of interface change
- Has persistent data change
- No code

### Check List for Tests

This PR has been tested by the at least one of the following methods:
This PR has been tested by at least one of the following methods:
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
Expand Down