Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #616] check store version while using API V2 #617

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

iosmanthus
Copy link
Member

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

Issue Number: close #616

What is changed and how does it work?

Check version bound in TiSession ctor.

Code changes

  • Has exported variable/fields change

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick the release branch

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@iosmanthus iosmanthus force-pushed the add-store-version-check-for-api-v2 branch from 8b0766e to 41e862c Compare June 17, 2022 10:52
pingyu
pingyu previously approved these changes Jun 17, 2022
Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #617 (e04c7ac) into master (7e6af29) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #617      +/-   ##
============================================
- Coverage     34.60%   34.55%   -0.06%     
  Complexity     1416     1416              
============================================
  Files           278      278              
  Lines         17352    17354       +2     
  Branches       1971     1972       +1     
============================================
- Hits           6005     5997       -8     
- Misses        10736    10744       +8     
- Partials        611      613       +2     
Impacted Files Coverage Δ
src/main/java/org/tikv/common/Version.java 0.00% <ø> (ø)
src/main/java/org/tikv/common/TiSession.java 70.37% <100.00%> (+0.13%) ⬆️
src/main/java/io/grpc/stub/ClientCalls.java 46.20% <0.00%> (-2.32%) ⬇️
...ty/handler/codec/http2/Http2ConnectionHandler.java 46.45% <0.00%> (-1.72%) ⬇️
...rc/main/java/io/grpc/netty/NettyClientHandler.java 56.03% <0.00%> (-0.87%) ⬇️
src/main/java/io/grpc/internal/ClientCallImpl.java 56.58% <0.00%> (-0.49%) ⬇️
.../main/java/org/tikv/common/region/RegionCache.java 50.92% <0.00%> (+1.85%) ⬆️
...va/org/tikv/common/region/StoreHealthyChecker.java 75.94% <0.00%> (+2.53%) ⬆️
...g/tikv/common/operation/iterator/ScanIterator.java 78.94% <0.00%> (+2.63%) ⬆️
src/main/java/org/tikv/common/region/TiStore.java 74.35% <0.00%> (+12.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e6af29...e04c7ac. Read the comment docs.

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@sunxiaoguang
Copy link
Member

LGTM

@sunxiaoguang
Copy link
Member

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@iosmanthus iosmanthus merged commit d6a15c4 into tikv:master Jun 20, 2022
@iosmanthus iosmanthus deleted the add-store-version-check-for-api-v2 branch June 20, 2022 14:05
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Jun 20, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.3 in PR #620

iosmanthus added a commit that referenced this pull request Jun 20, 2022
Co-authored-by: iosmanthus <dengliming@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check store version bound while creating V2 client
4 participants