-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[close #616] check store version while using API V2 #617
[close #616] check store version while using API V2 #617
Conversation
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
8b0766e
to
41e862c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
============================================
- Coverage 34.60% 34.55% -0.06%
Complexity 1416 1416
============================================
Files 278 278
Lines 17352 17354 +2
Branches 1971 1972 +1
============================================
- Hits 6005 5997 -8
- Misses 10736 10744 +8
- Partials 611 613 +2
Continue to review full report at Codecov.
|
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
LGTM |
/merge |
/run-all-tests |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-3.3 in PR #620 |
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Issue Number: close #616
What is changed and how does it work?
Check version bound in TiSession ctor.
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Related changes