-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[close #635] constraint the getMember timeout by inject a backoffer #636
[close #635] constraint the getMember timeout by inject a backoffer #636
Conversation
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
============================================
+ Coverage 34.68% 34.96% +0.28%
- Complexity 1420 1435 +15
============================================
Files 278 278
Lines 17358 17361 +3
Branches 1972 1974 +2
============================================
+ Hits 6020 6071 +51
+ Misses 10726 10675 -51
- Partials 612 615 +3
Continue to review full report at Codecov.
|
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-3.3 in PR #637 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: iosmanthus <dengliming@pingcap.com>
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Issue Number: close #635
Problem Description:
The
getMembers
is not limited by abackoffer
, which might cause the exception will not throw in time. For example, a user might set the timeout of a request to 400ms, but if the PD is disconnected, thegetMembers
might sleep more than 400ms since thebackoffer
it used is not passed from the upper code.What is changed and how does it work?
Inject a
backoffer
forgetMembers
and check timeout before acquiring a channel from the pool.Check List for Tests
This PR has been tested by at least one of the following methods:
Related changes