Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #693] Add test for RangeSplitter #694

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Conversation

shiyuhang0
Copy link
Collaborator

Signed-off-by: shiyuhang 1136742008@qq.com

What problem does this PR solve?

Issue Number: close #693
Problem Description: Add test for RangeSplitter

What is changed and how does it work?

Add test for RangeSplitter. reference: https://github.com/pingcap/tispark/blob/release-3.1/tikv-client/src/test/java/com/pingcap/tikv/util/RangeSplitterTest.java

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has methods of interface change
  • Has persistent data change
  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression, WHY: TBD
  • Increased code complexity, WHY: TBD
  • Breaking backward compatibility, WHY: TBD
  • NO side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note
  • NO related changes

Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 37.19% // Head: 37.97% // Increases project coverage by +0.77% 🎉

Coverage data is based on head (6eb836f) compared to base (a459a6e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #694      +/-   ##
============================================
+ Coverage     37.19%   37.97%   +0.77%     
- Complexity     1565     1597      +32     
============================================
  Files           278      278              
  Lines         17386    17386              
  Branches       1978     1978              
============================================
+ Hits           6467     6602     +135     
+ Misses        10268    10124     -144     
- Partials        651      660       +9     
Impacted Files Coverage Δ
...rc/main/java/io/grpc/netty/NettyClientHandler.java 56.03% <0.00%> (-0.22%) ⬇️
src/main/java/io/grpc/internal/ClientCallImpl.java 56.82% <0.00%> (+0.48%) ⬆️
src/main/java/org/tikv/common/TiConfiguration.java 71.59% <0.00%> (+0.76%) ⬆️
...ty/handler/codec/http2/Http2ConnectionHandler.java 49.87% <0.00%> (+1.71%) ⬆️
.../main/java/org/tikv/common/util/KeyRangeUtils.java 4.16% <0.00%> (+2.08%) ⬆️
...va/org/tikv/common/region/StoreHealthyChecker.java 73.41% <0.00%> (+3.79%) ⬆️
src/main/java/org/tikv/common/key/RowKey.java 41.50% <0.00%> (+41.50%) ⬆️
.../main/java/org/tikv/common/util/RangeSplitter.java 82.90% <0.00%> (+82.90%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shiyuhang0 shiyuhang0 changed the title [close #693]Add test for RangeSplitter [close #693] Add test for RangeSplitter Dec 26, 2022
@zhangyangyu zhangyangyu merged commit 3e02966 into tikv:master Dec 29, 2022
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Dec 29, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.3 in PR #698

zhangyangyu pushed a commit that referenced this pull request Dec 29, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Co-authored-by: shi yuhang <52435083+shiyuhang0@users.noreply.github.com>
shiyuhang0 added a commit to shiyuhang0/client-java that referenced this pull request Dec 30, 2022
Signed-off-by: shiyuhang <1136742008@qq.com>
iosmanthus pushed a commit to iosmanthus/client-java that referenced this pull request Dec 30, 2022
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
shiyuhang0 added a commit to shiyuhang0/client-java that referenced this pull request Dec 30, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Co-authored-by: shi yuhang <52435083+shiyuhang0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack test for Rangesplitter
3 participants