Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix byte overflow #728

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix byte overflow #728

merged 1 commit into from
Mar 7, 2023

Conversation

shiyuhang0
Copy link
Collaborator

@shiyuhang0 shiyuhang0 commented Mar 7, 2023

What problem does this PR solve?

#717

What is changed and how does it work?

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has methods of interface change
  • Has persistent data change
  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression, WHY: TBD
  • Increased code complexity, WHY: TBD
  • Breaking backward compatibility, WHY: TBD
  • NO side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note
  • NO related changes

Signed-off-by: shiyuhang <1136742008@qq.com>
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.15 🎉

Comparison is base (c1c804c) 37.98% compared to head (d624064) 38.14%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #728      +/-   ##
============================================
+ Coverage     37.98%   38.14%   +0.15%     
- Complexity     1611     1612       +1     
============================================
  Files           278      278              
  Lines         17482    17482              
  Branches       1986     1986              
============================================
+ Hits           6641     6668      +27     
+ Misses        10184    10157      -27     
  Partials        657      657              
Impacted Files Coverage Δ
src/main/java/org/tikv/common/codec/RowV2.java 0.00% <0.00%> (ø)
src/main/java/org/tikv/txn/TxnExpireTime.java 63.15% <0.00%> (-10.53%) ⬇️
src/main/java/io/grpc/internal/ClientCallImpl.java 57.14% <0.00%> (-0.25%) ⬇️
src/main/java/org/tikv/common/PDClient.java 57.79% <0.00%> (+0.91%) ⬆️
...n/java/org/tikv/common/util/ConcreteBackOffer.java 86.95% <0.00%> (+1.73%) ⬆️
.../main/java/org/tikv/common/AbstractGRPCClient.java 44.87% <0.00%> (+2.56%) ⬆️
...rc/main/java/io/grpc/netty/NettyClientHandler.java 59.69% <0.00%> (+4.74%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-srebot
Copy link
Collaborator

@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. get siglist: dial tcp 172.16.4.167:34000: connect: no route to host

@shiyuhang0 shiyuhang0 merged commit a523312 into tikv:master Mar 7, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 3.3: error checking out 3.3: exit status 1. output: error: pathspec '3.3' did not match any file(s) known to git

@shiyuhang0
Copy link
Collaborator Author

/cherry-pick release-3.3

@ti-chi-bot
Copy link
Member

@shiyuhang0: new pull request created to branch release-3.3: #729.

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants