Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[close #763] ignore invalid region while decoding EpochNotMatch #764

Closed
wants to merge 4 commits into from
Closed

[close #763] ignore invalid region while decoding EpochNotMatch #764

wants to merge 4 commits into from

Conversation

iosmanthus
Copy link
Member

What problem does this PR solve?

Issue Number: close #763

Problem Description: TBD

What has changed and how does it work?

Ignore invalid region while decoding EpochNotMatch

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has methods of interface change
  • Has persistent data change
  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression, WHY: TBD
  • Increased code complexity, WHY: TBD
  • Breaking backward compatibility, WHY: TBD
  • NO side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note
  • NO related changes

@iosmanthus
ignore invalid region while decoding EpochNotMatch
ec486be 
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
pingyu
pingyu previously approved these changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

shiyuhang0
shiyuhang0 previously approved these changes Sep 17, 2023
View reviewed changes
@iosmanthus iosmanthus dismissed stale reviews from shiyuhang0 and pingyu via ed647f3 September 17, 2023 06:14
@iosmanthus iosmanthus closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiyuhang0 shiyuhang0 shiyuhang0 left review comments

@pingyu pingyu pingyu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

decode EpochNotMatch should ignore invalid region
3 participants
@iosmanthus @pingyu @shiyuhang0