Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building integration tests without running them #69

Closed
nrc opened this issue Jun 19, 2019 · 5 comments
Closed

Allow building integration tests without running them #69

nrc opened this issue Jun 19, 2019 · 5 comments

Comments

@nrc
Copy link
Collaborator

nrc commented Jun 19, 2019

As an alternative, we could check for the PD_ADDR env var and pass the test if it is not present (or ignore it if it is not present at compile time?).

My reasoning is that when working on the library, it is nice to check that the integration tests still compile, even if we don't run them. Given we don't run them by default today, I don't think passing by default will give a false sense of security.

@Hoverbear what do you think?

@Hoverbear
Copy link
Contributor

Hoverbear commented Jun 19, 2019

Is it possible to do no-run on tests based on feature flags? Maybe we could use this feature to just enable running the tests (not building of them, which is always)?

@nrc
Copy link
Collaborator Author

nrc commented Jun 19, 2019

Is it possible to do no-run on tests based on feature flags? Maybe we could use this feature to just enable running the tests (not building of them, which is always)?

Good question! I think it should be possible, just a cfg_attr and that would be a good solution if it works.

@Hoverbear
Copy link
Contributor

Hmmm let me try it!

@Hoverbear
Copy link
Contributor

@nrc If we still require property-testing feature is that ok? Unfortunately due to the proptest macro it's difficult to include it in the build without that feature.

Hoverbear added a commit to Hoverbear/client-rust that referenced this issue Jun 20, 2019
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Hoverbear added a commit that referenced this issue Jun 20, 2019
Signed-off-by: Ana Hobden <operator@hoverbear.org>
@nrc
Copy link
Collaborator Author

nrc commented Jun 20, 2019

moving discussion to #68 since I'm finding it difficult to flick between tabs :-)

@nrc nrc changed the title Remove integration-tests feature? Allow building integration tests without running them Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants