-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove compat #149
Remove compat #149
Conversation
Signed-off-by: longfangsong <longfangsong@icloud.com>
Signed-off-by: longfangsong <longfangsong@icloud.com>
Signed-off-by: longfangsong <longfangsong@icloud.com>
Signed-off-by: longfangsong <longfangsong@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks!
@sticnarf PTAL Do you think we can land this now or should wait kvproto to change? I'm not sure when that might happen.
Looks great. @nrc Anyway, instead of using @longfangsong's personal fork, can we add a branch using futures 0.3 to tikv/kvproto before landing this PR? |
I prefer this solution too. |
@longfangsong could you rebase this PR please? Do we have a branch on kvproto we can use? |
I have a pr here: kvproto#633. But it hasn't get merged yet. |
# Conflicts: # Cargo.toml # src/kv_client/mod.rs # tikv-client-pd/src/cluster.rs
Signed-off-by: longfangsong <longfangsong@icloud.com>
Signed-off-by: longfangsong <longfangsong@icloud.com>
… .travis.yml Signed-off-by: longfangsong <longfangsong@icloud.com>
Signed-off-by: longfangsong <longfangsong@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, other than the maybe extra file
Thanks to @nrc Signed-off-by: longfangsong <longfangsong@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Signed-off-by: longfangsong longfangsong@icloud.com
Upgrade grpcio and remove the compaction code.
This should fix #148.
Note because of some dependency problems, we have to use my own fork of kvproto. And because of cargo #8258, we cannot use 1.43+ version of rust to build the project.These limitations have been removed after these crates and tools are updated into new version.