Skip to content

Update readme #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 12, 2020
Merged

Update readme #170

merged 11 commits into from
Oct 12, 2020

Conversation

ekexium
Copy link
Collaborator

@ekexium ekexium commented Sep 21, 2020

Update dependency, limit and add simple code examples.

@ekexium ekexium requested a review from nrc September 21, 2020 08:12
@ekexium ekexium force-pushed the update-readme branch 2 times, most recently from e07c953 to 581e626 Compare September 22, 2020 02:15
@ekexium ekexium changed the title update readme: add simple example code Update readme Sep 22, 2020
Signed-off-by: ekexium <ekexium@gmail.com>
@ekexium
Copy link
Collaborator Author

ekexium commented Sep 23, 2020

@nrc I added some content. Could you take another look?

Signed-off-by: ekexium <ekexium@gmail.com>
@ekexium ekexium closed this Sep 29, 2020
@ekexium ekexium deleted the update-readme branch September 29, 2020 06:16
@ekexium ekexium restored the update-readme branch September 29, 2020 06:16
@ekexium ekexium reopened this Sep 29, 2020
Signed-off-by: ekexium <ekexium@gmail.com>
@ekexium ekexium mentioned this pull request Oct 10, 2020
15 tasks
Copy link
Collaborator

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one typo, then land it.

re batch_scan/each_limit, is this behaviour specific to the Rust client? Does something else happen in TiDB?

README.md Outdated
| `batch_get` | `Iter<Key>` | `Iter<KvPair>` | Skip non-existent keys; Does not retain order |
| `lock_keys` | `KvPair` | `()` | |

For detailed behavior of each reqeust, please refer to the [doc](#Access-the-documentation).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For detailed behavior of each reqeust, please refer to the [doc](#Access-the-documentation).
For detailed behavior of each request, please refer to the [doc](#Access-the-documentation).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

batch_scan is a raw request. So TiDB should not have this problem.

Signed-off-by: ekexium <ekexium@gmail.com>
@nrc nrc merged commit aa10da8 into tikv:master Oct 12, 2020
@ekexium ekexium deleted the update-readme branch October 12, 2020 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants