Skip to content

Fill a missing situation in bound_range #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fill a missing situation in bound_range #174

wants to merge 3 commits into from

Conversation

ekexium
Copy link
Collaborator

@ekexium ekexium commented Sep 24, 2020

upper_bound can be Some(empty).

@ekexium
fill a missing situation in bound_range()
698522e 
Signed-off-by: ekexium <ekexium@gmail.com>
@ekexium
Copy link
Collaborator Author

ekexium commented Sep 24, 2020

/cc @nrc

@ekexium ekexium mentioned this pull request Sep 27, 2020
Closed
15 tasks
sticnarf
sticnarf approved these changes Sep 27, 2020
View reviewed changes
Copy link
Collaborator

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this as a temporary solution. But it is more like a design mistake if Some(empty) and None both represent unbounded

@ekexium ekexium closed this Sep 29, 2020
@ekexium ekexium deleted the fix-bound-range branch September 29, 2020 06:16
@ekexium ekexium restored the fix-bound-range branch September 29, 2020 06:16
@ekexium
Copy link
Collaborator Author

ekexium commented Sep 29, 2020

Close this PR as the change is already merged to master branch in #162 .

@ekexium ekexium deleted the fix-bound-range branch September 29, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sticnarf sticnarf sticnarf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekexium @sticnarf