Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dependency wait #47

Open
Connor1996 opened this issue Nov 25, 2019 · 3 comments
Open

Support dependency wait #47

Connor1996 opened this issue Nov 25, 2019 · 3 comments

Comments

@Connor1996
Copy link
Member

Connor1996 commented Nov 25, 2019

Is your feature request related to a problem? Please describe.

Make fail-point support dependencies (one fail-point wait for another before proceed)
we can refer to the implementation of rocksdb syncpoint https://github.com/facebook/rocksdb/blob/e9e0101ca46f00e8a456e69912a913d907be56fc/test_util/sync_point.h

Describe the solution you'd like

Support writting like this fail::cfg("point_A", "wait(point_B)")

  • wait indicates pause on point_A until point_B is passed.
  • wait_local indicates point_A is enabled when point_A and point_B are processed on same thread. And it will also pause on point_A until point_B is passed.

Additional context

part of #tikv/rust-rocksdb#361

@yiwu-arbug
Copy link

What's use case of wait_local?

@Connor1996
Copy link
Member Author

No use case for now @yiwu-arbug

@BusyJay
Copy link
Member

BusyJay commented Mar 27, 2020

I think with #50, this can be implemented on the application side easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants