Add callback for fail-rs #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
kennytm
reviewed
Mar 25, 2020
Little-Wallace
force-pushed
the
sync-point
branch
from
6ce0398
to
dc78bf1
Compare
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
kennytm
reviewed
Mar 25, 2020
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
BusyJay
reviewed
Mar 26, 2020
| F: Fn() + Send + Sync + 'static, | ||
| { | ||
| let mut registry = REGISTRY.registry.write().unwrap(); | ||
| let p = registry |
There was a problem hiding this comment.
It may be difficult... They are different.
BusyJay
approved these changes
Mar 26, 2020
kennytm
approved these changes
Mar 26, 2020
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Little-Wallace bupt2013211450@gmail.com
I want to add a new kind of action for
fail-rs, which can help TiKV be able to stop at some statement and call onecallbackfunction that set by tests. This feature will help use more convenient to deal with some tests which need to wait for a while, because we can pass a callback tofail_pointto notify test-thread to avoid waiting.