use environment variable to select link target #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BusyJay
force-pushed
the
busyjay/env-build
branch
from
8a179fd to
5ab8f89
Compare
|
ping |
|
How do we use now if we want to link static gRPC? |
|
It will build and link to gRPC statically by default. |
siddontang
reviewed
Sep 28, 2017
| } | ||
| } | ||
|
|
||
| fn main() { | ||
| let mut cc = Build::new(); | ||
|
|
||
| imp::build_or_link_grpc(&mut cc); | ||
| if get_env("GRPCIO_SYS_USE_PKG_CONFIG").map_or(false, |s| s == "1") { |
There was a problem hiding this comment.
seem using 1 is to build grpc?
There was a problem hiding this comment.
GRPCIO_SYS_USE_PKG_CONFIG=1 means use pkg-config to search for pre-installed grpc package and link to it.
|
LGTM PTAL @overvenus |
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in tikv/tikv#198 and considering the solutions other native crates have chosen (sfackler/rust-openssl#653), let's use environment variable to check link target.