Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv_jemalloc_ctl::version can show the version of the repository using jemalloc #76

Closed
espindola opened this issue Mar 28, 2024 · 0 comments · Fixed by #77
Closed

tikv_jemalloc_ctl::version can show the version of the repository using jemalloc #76

espindola opened this issue Mar 28, 2024 · 0 comments · Fixed by #77

Comments

@espindola
Copy link

If one creates a simple program with just

use tikv_jemalloc_ctl::version;
fn main() {
    println!("jemalloc version {}", version::read().unwrap());
}

and place it in a git repo and tag a revision with:

$ git tag -a 1.2.3 -m foo

The program will print

jemalloc version 1.2.3-0-....

Because the git repo that configure sees is the one with the test program.

I will try to write a PR.

espindola added a commit to espindola/jemallocator that referenced this issue Mar 28, 2024
espindola added a commit to espindola/jemallocator that referenced this issue Mar 28, 2024
espindola added a commit to espindola/jemallocator that referenced this issue Mar 28, 2024
Fixes tikv#76

Signed-off-by: Rafael Ávila de Espíndola <rafael@espindo.la>
espindola added a commit to espindola/jemallocator that referenced this issue Mar 29, 2024
This also changes the metadata of the version so that jemalloc still
reports the same version as before.

Fixes tikv#76

Signed-off-by: Rafael Ávila de Espíndola <rafael@espindo.la>
espindola added a commit to espindola/jemallocator that referenced this issue Mar 29, 2024
This also changes the metadata of the version so that jemalloc still
reports the same version as before.

Fixes tikv#76

Signed-off-by: Rafael Ávila de Espíndola <rafael@espindo.la>
espindola added a commit to espindola/jemallocator that referenced this issue Mar 29, 2024
This also changes the metadata of the version so that jemalloc still
reports the same version as before.

Fixes tikv#76

Signed-off-by: Rafael Ávila de Espíndola <rafael@espindo.la>
BusyJay pushed a commit that referenced this issue Apr 1, 2024
* Use --with-version when configuring jemalloc

This also changes the metadata of the version so that jemalloc still
reports the same version as before.

Fixes #76

Signed-off-by: Rafael Ávila de Espíndola <rafael@espindo.la>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant