Filter out -flto
args from cc
, don't set env vars that result in duplicated args
#144
+2
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to update
cc
in the Rust compiler is causing the build script intikv-jemalloc-sys
to fail to rungold
.gold
failing (or running at all) is unexpected, but the root cause is that the compiler flags now include-flto
where they didn't before.Fix for this is to strip out any
-flto
args whenjemalloc
gets the compiler command fromcc
- sincejemalloc
isn't producing object files to be linked into the final Rust compilation, it doesn't need to use LTO.Additionally, setting the
CPPFLAGS
andLDFLAGS
are redundant to settingCFLAGS
for the purposes of runningconfigure
: this results in the flags being triplicated in the C Compiler invocation.Validated by building the Rust compiler with this branch patched for
jemalloc
.