-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: bump 0.6.0 #95
*: bump 0.6.0 #95
Conversation
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
@@ -32,7 +33,7 @@ libc = { version = "^0.2.8", default-features = false } | |||
cc = "^1.0.13" | |||
|
|||
[features] | |||
default = ["stats", "background_threads_runtime_support"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering we are releasing a new minor version, "stats" is removed from the default features to make it easier to control features.
/cc @girlbossceo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any strong reason blocking us from just increasing the patch version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now jemalloc-sys will disable jemalloc stats explicitly if stats feature is not enabled. This may break crates that rely on jemalloc stats but not enable it explicitly. To avoid breaking compatibility (though it's a bug), stats feature was added to the default feature set. But it still breaks those crates that disable the default features. It's more clear to upgrade to a new minor version and ask everyone relies on stats feature to enable it explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
No description provided.