Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[to 48] Remove codes #115

Merged
merged 7 commits into from
Jun 9, 2022
Merged

[to 48] Remove codes #115

merged 7 commits into from
Jun 9, 2022

Conversation

zeminzhou
Copy link
Contributor

What problem does this PR solve?

Remove unused codes

Issue Number: close #48

Problem Description: TBD

What is changed and how does it work?

Remove unused codes

Code changes

  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test

Side effects

  • Possible performance regression, WHY: TBD
  • Increased code complexity, WHY: TBD
  • Breaking backward compatibility, WHY: TBD
  • No side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note
  • No related changes

zeminzhou and others added 3 commits April 18, 2022 15:58
Signed-off-by: zeminzhou <zeminzhou_@outlook.com>
Signed-off-by: zeminzhou <zhouzemin@ping.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@zeminzhou zeminzhou requested a review from pingyu June 9, 2022 06:39
zeminzhou added 3 commits June 9, 2022 14:39
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #115 (927c00a) into main (48a3c74) will increase coverage by 3.2803%.
The diff coverage is n/a.

❗ Current head 927c00a differs from pull request most recent head 191a9a9. Consider uploading reports for the commit 191a9a9 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##               main       #115        +/-   ##
================================================
+ Coverage   53.4580%   56.7383%   +3.2803%     
================================================
  Files           197        180        -17     
  Lines         19838      14232      -5606     
================================================
- Hits          10605       8075      -2530     
+ Misses         8265       5596      -2669     
+ Partials        968        561       -407     
Flag Coverage Δ
cdc 56.7383% <ø> (+3.2803%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdc/cdc/model/mounter.go 100.0000% <ø> (ø)
cdc/cdc/processor/pipeline/sink.go 62.9629% <ø> (ø)
cdc/cdc/sink/black_hole.go 81.4814% <ø> (+8.1481%) ⬆️
cdc/cdc/sink/sink.go 64.2857% <ø> (ø)
cdc/cdc/sink/tikv.go 27.0270% <ø> (+0.5719%) ⬆️
cdc/pkg/retry/retry_with_opt.go 90.9090% <0.0000%> (-4.5455%) ⬇️
cdc/cdc/processor/processor.go 61.5384% <0.0000%> (-0.5918%) ⬇️
cdc/pkg/p2p/client.go 84.6774% <0.0000%> (ø)
cdc/pkg/p2p/server.go 84.9099% <0.0000%> (ø)
cdc/pkg/orchestrator/etcd_worker.go 81.0924% <0.0000%> (+0.8403%) ⬆️
... and 2 more

Copy link
Collaborator

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM~

@@ -1,333 +0,0 @@
// Copyright 2020 PingCAP, Inc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be useful for test of puller ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From codes, the mock_puller.go is only used for "cdc/sink/codec/avro_test.go".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@pingyu pingyu merged commit cb44b9c into tikv:main Jun 9, 2022
@zeminzhou zeminzhou deleted the remove-codes branch July 4, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiKV CDC Development Tasks
2 participants