-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[to 48] Remove codes #115
[to 48] Remove codes #115
Conversation
Signed-off-by: zeminzhou <zeminzhou_@outlook.com>
Signed-off-by: zeminzhou <zhouzemin@ping.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
================================================
+ Coverage 53.4580% 56.7383% +3.2803%
================================================
Files 197 180 -17
Lines 19838 14232 -5606
================================================
- Hits 10605 8075 -2530
+ Misses 8265 5596 -2669
+ Partials 968 561 -407
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM~
@@ -1,333 +0,0 @@ | |||
// Copyright 2020 PingCAP, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be useful for test of puller
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From codes, the mock_puller.go is only used for "cdc/sink/codec/avro_test.go".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
What problem does this PR solve?
Remove unused codes
Issue Number: close #48
Problem Description: TBD
What is changed and how does it work?
Remove unused codes
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes