[to #48] remove mount metircs #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zeminzhou <zeminzhou_@outlook.com>
Signed-off-by: zeminzhou <zhouzemin@ping.com>
zz-jason
reviewed
Apr 19, 2022
Comment on lines
-49
to
-54
| // Sorter metrics | ||
| // sorter.InitMetrics(registry) | ||
| // memory.InitMetrics(registry) | ||
| // unified.InitMetrics(registry) | ||
| // leveldb.InitMetrics(registry) | ||
| // redowriter.InitMetrics(registry) |
There was a problem hiding this comment.
how about just removing them instead of commenting them out?
There was a problem hiding this comment.
yes, we should remove them.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zeminzhou zeminzhou_@outlook.com
What problem does this PR solve?
Issue Number: to #48
Problem Description:
The mount has been removed, related codes should be removed.
What is changed and how does it work?
Remove metrics code for mount.
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods: