Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall back to coarsetime #32

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Fall back to coarsetime #32

merged 2 commits into from
Jan 23, 2024

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Jan 23, 2024 •
edited
Loading

close #31

@zhongzc
Fall back to coarsetime
dd394d5 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc requested a review from andylokandy January 23, 2024 07:12
@zhongzc
fix windows unstable
714d490 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc
Copy link
Contributor Author

zhongzc commented Jan 23, 2024

@andylokandy PTAL

@zhongzc zhongzc merged commit 18bd3ea into tikv:master Jan 23, 2024
4 checks passed
@zhongzc zhongzc deleted the zhongzc/intro-coarse-time branch January 23, 2024 08:21
@andylokandy
Copy link
Contributor

Do you think adding a wasm ci will be a good idea?

@zhongzc
Copy link
Contributor Author

zhongzc commented Jan 23, 2024

Do you think adding a wasm ci will be a good idea?

Yes, it seems we can follow https://rustwasm.github.io/wasm-bindgen/wasm-bindgen-test/continuous-integration.html#github-actions to achieve that.

@andylokandy andylokandy mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andylokandy andylokandy andylokandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not compatible with WASM (wasm32-unknown-unknown)
2 participants
@zhongzc @andylokandy