address the comment

Signed-off-by: Ryan Leung <rleungx@gmail.com>

pkg/mcs/scheduling/server/grpc_service.go

@@ -324,7 +324,7 @@ func (s *Service) AskBatchSplit(_ context.Context, request *schedulingpb.AskBatc
 	// If region splits during the scheduling process, regions with abnormal
 	// status may be left, and these regions need to be checked with higher
 	// priority.
-	c.GetCoordinator().GetCheckerController().AddPendingProcessedRegions(recordRegions...)
+	c.GetCoordinator().GetCheckerController().AddPendingProcessedRegions(false, recordRegions...)
 
 	return &schedulingpb.AskBatchSplitResponse{
 		Header: s.header(),

pkg/schedule/checker/checker_controller.go

@@ -311,7 +311,7 @@ func (c *Controller) tryAddOperators(region *core.RegionInfo) {
 		c.opController.AddWaitingOperator(ops...)
 		c.RemovePendingProcessedRegion(id)
 	} else {
-		c.AddPendingProcessedRegions(id)
+		c.AddPendingProcessedRegions(true, id)
 	}
 }
 
@@ -331,9 +331,9 @@ func (c *Controller) GetPendingProcessedRegions() []uint64 {
 }
 
 // AddPendingProcessedRegions adds the pending processed region into the cache.
-func (c *Controller) AddPendingProcessedRegions(ids ...uint64) {
+func (c *Controller) AddPendingProcessedRegions(needCheckLen bool, ids ...uint64) {
 	for _, id := range ids {
-		if c.pendingProcessedRegions.Len() > DefaultPendingRegionCacheSize {
+		if needCheckLen && c.pendingProcessedRegions.Len() > DefaultPendingRegionCacheSize {
 			return
 		}
 		c.pendingProcessedRegions.Put(id, nil)
@@ -384,7 +384,7 @@ func (c *Controller) CheckSuspectRanges() {
 			if lastRegion.GetEndKey() != nil && bytes.Compare(lastRegion.GetEndKey(), keyRange[1]) < 0 {
 				c.AddSuspectKeyRange(lastRegion.GetEndKey(), keyRange[1])
 			}
-			c.AddPendingProcessedRegions(regionIDList...)
+			c.AddPendingProcessedRegions(false, regionIDList...)
 		}
 	}
 }

pkg/schedule/handler/handler.go

@@ -1124,7 +1124,7 @@ func (h *Handler) AccelerateRegionsScheduleInRange(rawStartKey, rawEndKey string
 		for _, region := range regions {
 			regionsIDList = append(regionsIDList, region.GetID())
 		}
-		co.GetCheckerController().AddPendingProcessedRegions(regionsIDList...)
+		co.GetCheckerController().AddPendingProcessedRegions(false, regionsIDList...)
 	}
 	return nil
 }
@@ -1151,7 +1151,7 @@ func (h *Handler) AccelerateRegionsScheduleInRanges(startKeys [][]byte, endKeys
 		for _, region := range regions {
 			regionsIDList = append(regionsIDList, region.GetID())
 		}
-		co.GetCheckerController().AddPendingProcessedRegions(regionsIDList...)
+		co.GetCheckerController().AddPendingProcessedRegions(false, regionsIDList...)
 	}
 	return nil
 }

pkg/schedule/scatter/region_scatterer.go

@@ -125,12 +125,12 @@ type RegionScatterer struct {
 	ordinaryEngine    engineContext
 	specialEngines    sync.Map
 	opController      *operator.Controller
-	addSuspectRegions func(regionIDs ...uint64)
+	addSuspectRegions func(bool, ...uint64)
 }
 
 // NewRegionScatterer creates a region scatterer.
 // RegionScatter is used for the `Lightning`, it will scatter the specified regions before import data.
-func NewRegionScatterer(ctx context.Context, cluster sche.SharedCluster, opController *operator.Controller, addSuspectRegions func(regionIDs ...uint64)) *RegionScatterer {
+func NewRegionScatterer(ctx context.Context, cluster sche.SharedCluster, opController *operator.Controller, addSuspectRegions func(bool, ...uint64)) *RegionScatterer {
 	return &RegionScatterer{
 		ctx:               ctx,
 		name:              regionScatterName,

pkg/schedule/splitter/region_splitter.go

@@ -58,11 +58,11 @@ func NewSplitRegionsHandler(cluster sche.ClusterInformer, oc *operator.Controlle
 type RegionSplitter struct {
 	cluster           sche.ClusterInformer
 	handler           SplitRegionsHandler
-	addSuspectRegions func(ids ...uint64)
+	addSuspectRegions func(bool, ...uint64)
 }
 
 // NewRegionSplitter return a region splitter
-func NewRegionSplitter(cluster sche.ClusterInformer, handler SplitRegionsHandler, addSuspectRegions func(ids ...uint64)) *RegionSplitter {
+func NewRegionSplitter(cluster sche.ClusterInformer, handler SplitRegionsHandler, addSuspectRegions func(bool, ...uint64)) *RegionSplitter {
 	return &RegionSplitter{
 		cluster:           cluster,
 		handler:           handler,

server/cluster/cluster_worker.go

@@ -165,7 +165,7 @@ func (c *RaftCluster) HandleAskBatchSplit(request *pdpb.AskBatchSplitRequest) (*
 	// If region splits during the scheduling process, regions with abnormal
 	// status may be left, and these regions need to be checked with higher
 	// priority.
-	c.AddPendingProcessedRegions(recordRegions...)
+	c.AddPendingProcessedRegions(false, recordRegions...)
 
 	resp := &pdpb.AskBatchSplitResponse{Ids: splitIDs}
 

server/cluster/scheduling_controller.go

@@ -404,10 +404,10 @@ func (sc *schedulingController) PauseOrResumeChecker(name string, t int64) error
 }
 
 // AddPendingProcessedRegions adds regions to suspect list.
-func (sc *schedulingController) AddPendingProcessedRegions(regionIDs ...uint64) {
+func (sc *schedulingController) AddPendingProcessedRegions(needCheckLen bool, regionIDs ...uint64) {
 	sc.mu.RLock()
 	defer sc.mu.RUnlock()
-	sc.coordinator.GetCheckerController().AddPendingProcessedRegions(regionIDs...)
+	sc.coordinator.GetCheckerController().AddPendingProcessedRegions(needCheckLen, regionIDs...)
 }
 
 // GetPendingProcessedRegions gets all suspect regions.