Skip to content

Commit

Permalink
add a comment
Browse files Browse the repository at this point in the history
Signed-off-by: Boyang Lyu <boyangly@gmail.com>
  • Loading branch information
JackL9u committed Aug 16, 2024
1 parent e3517c8 commit 3c1af75
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions tests/integrations/client/http_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -899,8 +899,8 @@ func (suite *httpClientTestSuite) TestGetGCSafePoint() {
re.Equal("Delete service GC safepoint successfully.", msg)
}

_, err4 := client.DeleteGCSafePoint(ctx, "gc_worker")
re.Error(err4)
_, err = client.DeleteGCSafePoint(ctx, "gc_worker")
re.Error(err)

// check that the safepoitns are indeed deleted
l, err = client.GetGCSafePoint(ctx)
Expand Down
2 changes: 1 addition & 1 deletion tools/pd-ctl/tests/safepoint/safepoint_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,6 @@ func TestSafepoint(t *testing.T) {
output, err = tests.ExecuteCommand(cmd, args...)
re.NoError(err)

// try again
// output should be an error message
re.Equal("Failed to delete service GC safepoint: request pd http api failed with status: '500 Internal Server Error', body: '\"cannot remove service safe point of gc_worker\"'\n", string(output))
}

0 comments on commit 3c1af75

Please sign in to comment.