fix invalidate

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
tikv · Mar 16, 2022 · 4c08c71 · 4c08c71
1 parent 521e0b9
commit 4c08c71
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/server/api/scheduler_test.go b/server/api/scheduler_test.go
@@ -150,6 +150,9 @@ func (s *testScheduleSuite) TestAPI(c *C) {
 				})
 				c.Assert(err, NotNil)
 				c.Assert(err.Error(), Equals, "\"invalid batch size which should be an integer between 1 and 10\"\n")
+				resp = make(map[string]interface{})
+				c.Assert(readJSON(testDialClient, listURL, &resp), IsNil)
+				c.Assert(resp["batch"], Equals, 3.0)
 				// empty body
 				err = postJSON(testDialClient, updateURL, nil, func(res []byte, code int) {
 					c.Assert(code, Equals, 500)

diff --git a/server/schedulers/balance_leader.go b/server/schedulers/balance_leader.go
@@ -100,6 +100,7 @@ func (conf *balanceLeaderSchedulerConfig) Update(data []byte) (int, interface{})
 	newc, _ := json.Marshal(conf)
 	if !bytes.Equal(oldc, newc) {
 		if !conf.validate() {
+			json.Unmarshal(oldc, conf)
 			return http.StatusBadRequest, "invalid batch size which should be an integer between 1 and 10"
 		}
 		conf.persistLocked()