address the comment

Signed-off-by: yisaer <disxiaofei@163.com>
tikv · May 14, 2021 · 5ecebae · 5ecebae
1 parent 55cff6f
commit 5ecebae
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/server/statistics/hot_peer_cache.go b/server/statistics/hot_peer_cache.go
@@ -169,9 +169,10 @@ func (f *hotPeerCache) CollectExpiredItems(region *core.RegionInfo) []*HotPeerSt
 
 // CheckPeerFlow checks the flow information of a peer.
 // Notice: CheckPeerFlow couldn't be used concurrently.
+// CheckPeerFlow will update oldItem's rollingLoads into newItem, thus we should use write lock here.
 func (f *hotPeerCache) CheckPeerFlow(peer *core.PeerInfo, region *core.RegionInfo) *HotPeerStat {
-	f.RLock()
-	defer f.RUnlock()
+	f.Lock()
+	defer f.Unlock()
 	interval := peer.GetInterval()
 	if Denoising && interval < HotRegionReportMinInterval {
 		return nil