refine algorithm

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
tikv · Apr 11, 2023 · 9c7acff · 9c7acff
1 parent 8a17518
commit 9c7acff
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/pkg/tso/keyspace_group_manager.go b/pkg/tso/keyspace_group_manager.go
@@ -524,10 +524,6 @@ func (kgm *KeyspaceGroupManager) updateKeyspaceGroupMembership(
 		} else {
 			sameMembership = false
 			kgm.keyspaceLookupTable.Store(newKeyspaces[j], groupID)
-			if keyspaceLookupTable == nil {
-				keyspaceLookupTable = make(map[uint32]struct{})
-			}
-			keyspaceLookupTable[newKeyspaces[j]] = struct{}{}
 			j++
 		}
 	}
@@ -554,14 +550,15 @@ func (kgm *KeyspaceGroupManager) updateKeyspaceGroupMembership(
 		if keyspaceLookupTable == nil {
 			keyspaceLookupTable = make(map[uint32]struct{})
 		}
-		for i, j = 0, 0; i < oldLen && j < newLen; {
-			if oldKeyspaces[i] == newKeyspaces[j] {
-				keyspaceLookupTable[oldKeyspaces[i]] = struct{}{}
+		for i, j = 0, 0; i < oldLen || j < newLen; {
+			if i < oldLen && j < newLen && oldKeyspaces[i] == newKeyspaces[j] {
+				keyspaceLookupTable[newKeyspaces[j]] = struct{}{}
 				i++
 				j++
-			} else if oldKeyspaces[i] < newKeyspaces[j] {
+			} else if i < oldLen && j < newLen && oldKeyspaces[i] < newKeyspaces[j] || j == newLen {
 				i++
 			} else {
+				keyspaceLookupTable[newKeyspaces[j]] = struct{}{}
 				j++
 			}
 		}