address comments

Signed-off-by: shirly <AndreMouche@126.com>

server/schedule/checker/joint_state_checker.go

@@ -45,7 +45,7 @@ func (c *JointStateChecker) Check(region *core.RegionInfo) *operator.Operator {
 	if !core.IsInJointState(region.GetPeers()...) {
 		return nil
 	}
-	op, err := operator.NewLeaveJointStateOperator(c.cluster, region)
+	op, err := operator.CreateLeaveJointStateOperator(operator.OpDescLeaveJointState, c.cluster, region)
 	if err != nil {
 		checkerCounter.WithLabelValues("joint_state_checker", "create-operator-fail").Inc()
 		log.Debug("fail to create leave joint state operator", errs.ZapError(err))

server/schedule/operator/create_operator.go

@@ -217,12 +217,8 @@ func CreateScatterRegionOperator(desc string, ci ClusterInformer, origin *core.R
 		Build(0)
 }
 
-const opDescLeaveJointState = "leave-joint-state"
-
-// NewLeaveJointStateOperator  creates an operator that let region leave joint state with default desc.
-func NewLeaveJointStateOperator(ci ClusterInformer, origin *core.RegionInfo) (*Operator, error) {
-	return CreateLeaveJointStateOperator(opDescLeaveJointState, ci, origin)
-}
+// OpDescLeaveJointState is the expected desc for LeaveJointStateOperator.
+const OpDescLeaveJointState = "leave-joint-state"
 
 // CreateLeaveJointStateOperator creates an operator that let region leave joint state.
 func CreateLeaveJointStateOperator(desc string, ci ClusterInformer, origin *core.RegionInfo) (*Operator, error) {

server/schedule/operator/operator.go

@@ -401,9 +401,9 @@ func (o *Operator) GetAdditionalInfo() string {
 	return ""
 }
 
-// IsLeaveJointStateOperator returns true if the desc is opDescLeaveJointState.
+// IsLeaveJointStateOperator returns true if the desc is OpDescLeaveJointState.
 func (o *Operator) IsLeaveJointStateOperator() bool {
-	return strings.EqualFold(o.desc, opDescLeaveJointState)
+	return strings.EqualFold(o.desc, OpDescLeaveJointState)
 }
 
 // these values are used for unit test.